-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validator: Reduce severity of release-time-missing on snapshot releases #650
Open
jayaddison
wants to merge
6
commits into
ximion:main
Choose a base branch
from
jayaddison:issue-570/skip-release-time-missing-for-snapshots
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
validator: Reduce severity of release-time-missing on snapshot releases #650
jayaddison
wants to merge
6
commits into
ximion:main
from
jayaddison:issue-570/skip-release-time-missing-for-snapshots
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaddison
force-pushed
the
issue-570/skip-release-time-missing-for-snapshots
branch
2 times, most recently
from
August 18, 2024 21:57
2f54866
to
07d6bda
Compare
This is not quite what I meant in the bug report... Since there may be a release tomorrow I may just implement that change quickly (but not if the release is deferred to Thursday). |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jayaddison
changed the title
validator: Omit date validation for snapshot releases
validator: Reduce severity of release-time-missing on snapshot releases
Aug 28, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Logic: snapshot releases are allowed to omit the `date` attribute.
Logic: dates that do exist on snapshot releases should be validated.
…, even for snapshot releases
jayaddison
force-pushed
the
issue-570/skip-release-time-missing-for-snapshots
branch
from
August 28, 2024 13:21
089f4d8
to
4bda793
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #570.